Bug fix: Remove fallback from LCSC barcode part resolver#1302
Bug fix: Remove fallback from LCSC barcode part resolver#1302swdee wants to merge 3 commits intoPart-DB:masterfrom
Conversation
… is the ultimate source of truth.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1302 +/- ##
=========================================
Coverage 56.31% 56.32%
+ Complexity 8320 8319 -1
=========================================
Files 611 611
Lines 26726 26724 -2
=========================================
+ Hits 15050 15051 +1
+ Misses 11676 11673 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MayNiklas
left a comment
There was a problem hiding this comment.
Solves the issue for me 👍
|
I think it is useful to have a fallback using PartRepository::getPartBySPN with the lcsc part number. |
…ber, which scans the orderdetails DB table
This has been added in. |
|
The SPN resolval logic should also be part of the LCSC submethod (or we inline the complete method). And I think most people will have the LCSC product code as SPN (as that is the order number) not with the MPN. |
As discussed in #1297 this PR removes the fallback logic from the part resolver of LCSC codes. This resolves the issue where a similarly named manufacture part but with different LCSC code
pcnumber was being matched when it should not have been.